Fix bl unit for high strength characters #2041
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@StefanLeng Do you want it displayed such as "2000 lb"? |
|
Yes. I just display the strings from system.liftingmoving, which includes the unit. Works for "normal" characters, but if the BL >= 1000, this string is still broken in 0.17.16. With a basic lift off 2000, it was "2 2,000 lb" in 0.17.15 and now is "2000 2.000 lb" in 0.17.16. This pull request makes it "2000 lb". See StefanLeng/gurps-categorized-sheet#9 for the situation under 0.17.15. Its still broken under 1.17.16, even if the leading value is now fixed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GGA 0.17.16 fixed issue #2039 for the Basic Lift value, but the unit is still broken. Its not displayed on the GGA sheets, but I use it in the Cathegorized Character Sheet module.
This pull request extends the fix to also fix the unit.